Skip to content

[3.3] Upgrade HashedWheelTimer with the same class of latest Netty 4.2 #15739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 9 commits into
base: 3.3
Choose a base branch
from
Open

[3.3] Upgrade HashedWheelTimer with the same class of latest Netty 4.2 #15739

wants to merge 9 commits into from
+1,853 −154

Conversation

@zrlw
Copy link
Contributor

@zrlw zrlw commented Oct 24, 2025 •
edited
Loading

What is the purpose of the change?

  1. Upgrade HashedWheelTimer content based on latest Netty's HashedWheelTimer(Oct 17, 2025): https://github.com/netty/netty/blob/d7b39b4f48aff9f7efd2fe0aa8841e2aa13e2874/common/src/main/java/io/netty/util/HashedWheelTimer.java (netty/netty@d7b39b4)
  2. Add jctools-core to transitive dependencies of dubbo-all and dubbo-all-shaded because latest Netty's HashedWheelTimer took MpscQueue of jctools-core as its queue but all dubbo sub-modules dependency optional flag are set to true.
  3. This pr includes Remove jdk9-compile profile from pom.xml to support Unsafe compilation at jdk9+ #15755 since latest Netty's HashedWheelTimer contains a lot of codes that calls sun.misc.Unsafe.

Checklist

  • Make sure there is a GitHub_issue field for the change.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Make sure gitHub actions can pass. Why the workflow is failing and how to fix it?

@codecov-commenter
Copy link

codecov-commenter commented Nov 5, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 33.09859% with 475 lines in your changes missing coverage. Please review.
✅ Project coverage is 60.53%. Comparing base (f284fab) to head (05e4f12).

Files with missing lines Patch % Lines
...rg/apache/dubbo/common/timer/HashedWheelTimer.java 33.00% 407 Missing and 68 partials ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##                3.3   #15739      +/-   ##
============================================
- Coverage     60.76%   60.53%   -0.24%     
+ Complexity    11712    11710       -2     
============================================
  Files          1938     1938              
  Lines         88646    89293     +647     
  Branches      13379    13511     +132     
============================================
+ Hits          53866    54051     +185     
- Misses        29257    29656     +399     
- Partials       5523     5586      +63
Flag Coverage Δ
integration-tests-java21 32.31% <25.07%> (-0.14%) ⬇️
integration-tests-java8 32.32% <23.09%> (-0.12%) ⬇️
samples-tests-java21 31.94% <25.07%> (-0.11%) ⬇️
samples-tests-java8 29.68% <23.09%> (+0.07%) ⬆️
unit-tests-java11 58.79% <27.32%> (-0.29%) ⬇️
unit-tests-java17 58.31% <27.60%> (-0.24%) ⬇️
unit-tests-java21 58.30% <27.60%> (-0.27%) ⬇️
unit-tests-java25 58.19% <19.43%> (-0.31%) ⬇️
unit-tests-java8 58.77% <25.74%> (-0.32%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@zrlw zrlw closed this Nov 10, 2025
@zrlw zrlw deleted the 3.3-upgrade-netty-HashedWheelTimer branch November 10, 2025 04:20
@zrlw zrlw restored the 3.3-upgrade-netty-HashedWheelTimer branch November 10, 2025 04:21
@zrlw zrlw reopened this Nov 10, 2025
@zrlw zrlw force-pushed the 3.3-upgrade-netty-HashedWheelTimer branch from af16f88 to af176d7 Compare November 10, 2025 04:26
@zrlw zrlw changed the title [Discussion] Upgrade HashedWheelTimer with the same class at latest Netty [Discussion] Upgrade HashedWheelTimer with the same class of latest Netty 4.2 Nov 10, 2025
@zrlw zrlw force-pushed the 3.3-upgrade-netty-HashedWheelTimer branch 3 times, most recently from 24fe34e to f18af31 Compare November 11, 2025 14:59
@zrlw zrlw changed the title [Discussion] Upgrade HashedWheelTimer with the same class of latest Netty 4.2 [3.3] Upgrade HashedWheelTimer with the same class of latest Netty 4.2 Nov 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@zrlw @codecov-commenter